ActiveTriples / linked-data-fragments

Basic linked data fragments endpoint.
Creative Commons Zero v1.0 Universal
15 stars 0 forks source link

Rails engine? #8

Open jamesvanmil opened 9 years ago

jamesvanmil commented 9 years ago

Following the lead of Questioning Authority, I think this should be a Rails engine. Any good reason not to do this?

tpendragon commented 9 years ago

With the idea being that you can mount the app in other apps? I'm not particularly against it, just no experience in writing them. Can you spin it up as an engine?

jamesvanmil commented 9 years ago

Yeah that's my thought. I think I can modify the existing code base to enginfy it without interfering with other work.

no-reply commented 7 years ago

I'm working on a refactor that makes these fragments mountable. This may take the form of a larger refactor that moves the core code out into a Rack module. Updates to come.

no-reply commented 7 years ago

There's a branch that makes this mountable at: https://github.com/ActiveTriples/linked-data-fragments/compare/feature/rack-server

Mounting instruction are at: https://github.com/ActiveTriples/linked-data-fragments/compare/feature/rack-server#diff-a334eb2b47b576b3194fbb8e04a94474R11

hackartisan commented 7 years ago

@no-reply is this issue closed? LDCX notes reference 'axing rails engine' which would imply yes.

However, notes from LDCX indicate that there is a bit of final alignment to do; can you give more details on whether that is a matter of PRing existing work or creating a new ticket to... discuss? take some (what?) action?

"Other topic with respect to LDF gem, Tom took logic out of rails part of that gem and in DCE branch, there are 2 equivalent server applications. Share all logic except routing. Would advocate possibly axing rails engine, no reason you can’t mount any rails app you like to rack. Want buy-in for rack instead of rails (rails is heavyweight for this work context)" (from https://docs.google.com/document/d/1yr7dIlKzWmaVLf-2easbaQvY5UF8tf0_ylr8RIKWprY/edit)

jcoyne commented 7 years ago

Hmm, I was unable to be at the LDCX discussion, but I'm still leaning towards possibly making this an engine as it would make the deployment story much easier.

jcoyne commented 7 years ago

I would like to hear more about the non-rails server applications that @no-reply has devised.