ActivearkJWT / grunt-font-optimizer

Optimize TTF fonts with Grunt
MIT License
18 stars 5 forks source link

Need to handle non UTF-8 characters #4

Closed btilford closed 9 years ago

btilford commented 9 years ago

Using the following chars argument you get the error Wide character in subroutine entry at Font/Subsetter.pm line 1496

ABCDEFGHIJGKLMNOPQRSTUVWXYZabcdefghijgklmnopqrstuvwxyz 1234567890 ½¼ !@#$%^&*()-_=+'\";:,.<>/?[]{}\\|~¡£¢§¶ªº°·± àáäâéèëêìíïîòóöôùúüûøßçæñÀÁÄÂÉÈËÊÌÍÏÎÒÓÖÔÙÚÜÛØÇÆÑ ®©¿™∞•–—≠⁄€ ‹›fifl‡‚± “” ‘’ œ …≤≥`

Using Perl 5.18.2 NodeJS 0.10.32

jehna commented 9 years ago

From a quick look, I'd say the bug is on the Google Font Directory's code.

Updating the Google Font Directory code could fix the bug, otherwise you can file an issue at Google Font Directory's bug tracker

btilford commented 9 years ago

It's actually the argument passed to the perl script that needs to be encoded.

jehna commented 9 years ago

Yes, silly me, remembered a whole another project. Sorry about that.

jehna commented 9 years ago

Remembering more, this project was originally based on Google Font Directory's code. As a reminder from those times, there's still a faulty attribution reference in the readme file.

At some stage, the code was changed to use a perl library from Philip Taylor, but the attribution was somehow mixed to Google Font Directory.

Opening a new issue for the attribution, closing this one. Thank you @btilford for the fix!