search

Activisme-be / Blade-github-octicons

A package to easily make use of Github Octicons in your Laravel Blade views.
MIT License
5 stars 5 forks source link

Add usage of Blade icons generator #30

Closed mallardduck closed 3 years ago

mallardduck commented 3 years ago

Hiya!

This PR solves for https://github.com/Activisme-be/Blade-github-octicons/issues/29 by using the new generator script feature added into blade-icons. I've opted to use a git submodule to keep the source icons at a specific state. Currently the submodule is checked out to the HEAD of the v14.2.2 tag.

When a new release upstream happens you can simple change into the dist folder, checkout the new tag, and then run the blade-icons generator script. More docs on that generator script are here: https://github.com/blade-ui-kit/blade-icons#generating-icons

Tjoosten commented 3 years ago

Hey @mallardduck,

Sorry for the late response. Like i told on twitter we got some volunteering work going on here in Belgium. Thanks for the PR will merge it for now and tag it later in a release. When i synched the octicons from primercss with this package.

Kind regards, Tim Joosten

Tjoosten commented 2 years ago

Hey @mallardduck,

Sorry for the very late response. Once again i tried to sync the submodules. But unfortunately im not familiar with git submodules. Can u tell me how i checkout the git submodules?

Kind regards, Tim Joosten

mallardduck commented 2 years ago

Running this:

git submodule update --init

Should initialize the submodule to the version in this PR. Then you can either: use CLI or your git GUI to interact with the folder the submodule is in.

For instance change dir to the subdirectory, then git checkout the most recent tagged release. Once the submodule is on the tagged version you can commit the change for the submodule version on the main repo.