search

Activisme-be / Blade-github-octicons

A package to easily make use of Github Octicons in your Laravel Blade views.
MIT License
5 stars 5 forks source link

Icons don't support filling color #9

Closed driesvints closed 4 years ago

driesvints commented 4 years ago

Hi there,

I'm opening this issue because we're currently working on integrating an icon search into the upcoming blade-ui-kit.com website. For this we need to be able to control the look and feel of the icons, especially its color.

It seems that this icon set doesn't supports filling its color yet. For this reason we've currently excluded your icon set from the search. It would be cool if you could fix this so your icon set can also be included in the global search.

Details

Here's an example of your icon missing either fill="none" stroke="currentColor" (outline icons) or fill="currentColor" (solid icons).

How to fix

Apply fill="none" stroke="currentColor" to any outline icons (Heroicons example) or fill="currentColor" to any solid icons (Heroicons example).

Also make sure you remove any attributes that don't belong on the icons like id, class, width & height, etc.

Please respond to this issue as soon as you've been able to fix this and tag a release and we'll include your library in the search.

Tjoosten commented 4 years ago

Hey Dries,

Currently i have not much spare time. But i will try to fix this issue in the weekend. And thank you for the self explaining issue ticket.

Tjoosten commented 4 years ago

Hey @driesvints

I've added fill="currentColor" to all the 399 icons. I hope that is enough for solving your ticket. Feel free to review the open PR (#11)

driesvints commented 4 years ago

Lgtm. Let me know when it's merged and tagged.

Tjoosten commented 4 years ago

Hey @driesvints ,

The changes are tagged in v1.2.0. If everything is good. You can pull in the changes with composer. If there is any error or bug. Feel free to open a new issue.

Kind regards, Tim Joosten

driesvints commented 4 years ago

That seems to have done it. Thanks! I've included the set in the search for the upcoming blade-ui-kit.com website.