ActivitySim / activitysim-prototype-mtc

The canonical prototype MTC model.
BSD 3-Clause "New" or "Revised" License
1 stars 2 forks source link

Benchmarking crashes in sharrow `compile` #15

Closed i-am-sijia closed 4 months ago

i-am-sijia commented 5 months ago

When I attempted to run MTC benchmarking with the latest ActivitySim and Sharrow, it crashed in the sharrow compile mode. Complaining about utility not matching. I tried again from a fresh installation, it crashed at the same point.

To replicate:

image

activitysim.log

jpn-- commented 4 months ago

This error occurred due to the atol parameter on the check being set to 0. We can see in the output the max absolute difference is only 3.278e-07, which is quite small but not actually zero. So in https://github.com/ActivitySim/activitysim/pull/878 I have adjusted the default atol parameter on these checks in ActivitySim to 1e-06. I have run this same test per the notes above and I now see no error.