Closed fscottfoti closed 9 years ago
One other thing to add to this list is naming conventions - PEP8 conventions say variables should be named number_persons_age_5_to_15 while most of the variables currently are named like numPersAge5to15. I've changed most of these in the code to match PEP8 conventions but want to make sure people are OK with this. Column names in tables might need to be changed too which I haven't done yet.
@fscottfoti Thank you for pulling together this thorough update on the progress for the last two weeks. It's been nice to follow the progress you and Matt are making via the frequent documentation in GitHub.
A few thoughts on where we are and where we may want to go on the issues outlined above.
I concur with @danielsclint that this update was very fun to review and I appreciate the sending of this report with links to everything. Pretty Sweet.
One thing that may be useful in the future is to discus specific design questions in their own issues so they are easier to follow. But for now, I will follow Clint's lead and just add my thoughts here.
Config file formats
/examples/
and defaults
will be important. The way I see it eventually working is that ActivitySim is a code base that I (well the future person playing my role at SFCTA) would reference to implement CHAMP. i.e. CHAMP is it's own git repo full of specifications and set of routines to run champ, but it is just using ActiviySIM building blocks (that will probably look a lot like /example/TravelModelOne
I would reallllly like to separate the "codebase" from the "travel model".Performance
It was interesting to keep up with software development over the past couple of weeks, very transparent process, much appreciated, many thanks. That said, a few comments:
I agree that we should not have to have Urbansim installed in order to run Activitysim, though leveraging the Urbansim architecture is most definitely ok and the way to go.
Distributed processing across servers should be as flexible as possible.
CDAP as the next model component to tackle is one more step heading in the right direction with this project moving forward.
Progress since the last meeting
Infrastructure
Specific Models
DataFrame.eval
or straight Pythoneval
when there is an@
as the first character. Allows more flexibility in the csv than is provided in current yaml files.TAZ
) should occur in the choosers and is used as the origin id and the alternatives and is used as destination idThoughts?