search

ActivitySim / activitysim

An Open Platform for Activity-Based Travel Modeling
https://activitysim.github.io
BSD 3-Clause "New" or "Revised" License
189 stars 96 forks source link

Discrete Choice Model Capabilities #3

Closed jiffyclub closed 9 years ago

jiffyclub commented 9 years ago

UrbanSim has location choice models, but they are somewhat specialized to their application in real estate modeling. (For example, the LCMs always remove choices from the alternatives pool once they have been chosen.) As a first step toward adding models to ActibitySim we're working to generalize the discrete choice classes in UrbanSim so that they can be reused here. You can follow my work in the dcm branch in UrbanSim.

Also related to this, we've added tests of UrbanSim's MNL implementation to make sure it matches R's mlogit package. You can see that work in synthicity/urbansim#132.

jiffyclub commented 9 years ago

I've opened synthicity/urbansim#134 with the changes to support more general discrete choice modeling in urbansim.

fscottfoti commented 9 years ago

Is there any reason not to merge the DCM branch on UrbanSim and close this issue? I do use the changes in the MNL interaction in activitysim so it would be handy to depend on master rather than depending on the dcm branch.

jiffyclub commented 9 years ago

Yeah if you're using it let's merge it. I wasn't sure if any of the changes were actually being used.

fscottfoti commented 9 years ago

Sounds good - merge away!