search

ActivitySim / activitysim

An Open Platform for Activity-Based Travel Modeling
https://activitysim.github.io
BSD 3-Clause "New" or "Revised" License
191 stars 98 forks source link

Joint Tour Destination Changed to Use Non-Mandatory Destination Choice Model Settings #335

Closed danielsclint closed 3 years ago

danielsclint commented 4 years ago

In PR #325, the model configuration file for joint tour destination was pointed to use the same model specification as non_mandatory_tour_destination. For consistency sake, would it be better to keep each model self-contained in its own YAML?

https://github.com/ActivitySim/activitysim/blob/05a25f687e0c151c5a3bcbf4428d2b58dd2cc4f7/activitysim/abm/models/joint_tour_destination.py#L329-L330

toliwaga commented 4 years ago

Yes - and especially as there is such a file, but it is currently ignored (and missing a field)

The only thing is that sometimes (e.g. for mtctm1) it will be identical to non_mandatory_tour_destination.yaml

it would be nice to have a macro (like inherit_settings) that allows you to say something like:

include_settings: non_mandatory_tour_destination.yaml

danielsclint commented 3 years ago

This was dealt with in PR #342.