search

ActivitySim / activitysim

An Open Platform for Activity-Based Travel Modeling
https://activitysim.github.io
BSD 3-Clause "New" or "Revised" License
189 stars 96 forks source link

Trip mode choice for trips on at-work subtours #597

Open jpn-- opened 1 year ago

jpn-- commented 1 year ago

as reported by @jfdman

Trip mode choice for trips on at-work subtours aren’t being estimated.

AndrewTheTM commented 1 year ago

I ended up getting around this by commenting out a few lines (not sure that's the optimal approach, but I was able to get my work done):

https://github.com/ActivitySim/activitysim/blob/1e4ffc5cdd745c183b2b50385e457c8cfaa6c18d/activitysim/estimation/larch/mode_choice.py#L53 and the following line

https://github.com/ActivitySim/activitysim/blob/1e4ffc5cdd745c183b2b50385e457c8cfaa6c18d/activitysim/estimation/larch/mode_choice.py#L89

https://github.com/ActivitySim/activitysim/blob/1e4ffc5cdd745c183b2b50385e457c8cfaa6c18d/activitysim/estimation/larch/mode_choice.py#L93 and the following three

I'll note that this is not thoroughly tested and may cause issues in tour mode choice (since at-work is not part of that group).