search

ActivitySim / activitysim

An Open Platform for Activity-Based Travel Modeling
https://activitysim.github.io
BSD 3-Clause "New" or "Revised" License
194 stars 99 forks source link

tot_tours Hidden in Non-Mandatory Tour Frequency Code #656

Closed dhensle closed 2 months ago

dhensle commented 1 year ago

A variable named tot_tours is hard-coded in the non-mandatory tour frequency model: https://github.com/ActivitySim/activitysim/blob/main/activitysim/abm/models/non_mandatory_tour_frequency.py#L159.
This should really be exposed to the user and listed in the alternatives file instead.

JoeJimFlood commented 1 year ago

@dhensle Is what I did in #661 along the lines with what you were thinking? I am wondering if we should add a check that the total tours is actually the total number of nonmandatory tours for each alternative and raise an AssertionError if that's the case.