search

ActivitySim / activitysim

An Open Platform for Activity-Based Travel Modeling
https://activitysim.github.io
BSD 3-Clause "New" or "Revised" License
189 stars 96 forks source link

skip_sharrow setting doesn't work for some model steps #674

Open JoeJimFlood opened 1 year ago

JoeJimFlood commented 1 year ago

In order to get the latest ABM3 setup to run through while compiling Sharrow, I needed to skip it in a few steps. However, there are at least a couple of steps where the option doesn't work. @dhensle showed me how to edit the CDAP code to just not run Sharrow, and then I did something similar in joint tour frequency and composition.

jpn-- commented 1 year ago

Yeah, unfortunately ActivitySim has a lot of unique components, many of which use inconsistent settings or step through their computational processes in different ways. It makes it hard to take a "skip" message from a component config file and deliver it to the sharrow apply_flow through the mess of intermediate function calls. We can work on this as part of the general refactoring of component configs.

jpn-- commented 3 months ago

This is now addressed in #842, which provides a common interface pathway for sharrow control (skip, fastmath, and others potentially in the future)