[x] Add protect_columns to all core simulate functions. protect_columns is a setting under compute_settings that can be used to protect specific columns from being dropped. But it was not fully implemented for all core simulate functions.
[x] Protecting special columns in the ALT table from being dropped was done previously by hardcoding them in source code, like in simulate_sample.py: https://github.com/ActivitySim/activitysim/blob/1cb48c7acc2c377f4822e2521a19503842aaa495/activitysim/core/interaction_sample.py#L268 This is ok (and efficient) for tdd since it’s a generic variable, but less so for origin_destination since it’s a variable only relevant to the SANDAG xborder model. Furthermore, this crashes the ARC trip scheduling choice model. This PR moves the non-generic columns from source code to implementation-specific settings.
[x] Set up comupte_settings in trip_scheduling_choice.py
[x] Add protect_columns in parking_location_choice.py
This PR includes the following fixes:
protect_columnsto all core simulate functions.protect_columnsis a setting undercompute_settingsthat can be used to protect specific columns from being dropped. But it was not fully implemented for all core simulate functions.tddsince it’s a generic variable, but less so fororigin_destinationsince it’s a variable only relevant to the SANDAG xborder model. Furthermore, this crashes the ARC trip scheduling choice model. This PR moves the non-generic columns from source code to implementation-specific settings.comupte_settingsin trip_scheduling_choice.pyprotect_columnsin parking_location_choice.py