Harden aw-client - Githubissues

ActivityWatch / activitywatch

The best free and open-source automated time tracker. Cross-platform, extensible, privacy-focused.

https://activitywatch.net/

Mozilla Public License 2.0

12.25k stars 553 forks source link

Harden aw-client #170

Closed ErikBjare closed 6 years ago

ErikBjare commented 6 years ago

aw-client is currently not as resilient against failure as it ought to be.

Problems:

RequestQueue does not safely write back to disk on failure.
RequestQueue currently supports arbitrary queued requests, but it's not written with such things in mind (only heartbeats).

I found this library persist-queue which might be a better way to handle this.

Related issues:

https://github.com/ActivityWatch/activitywatch/issues/164

ErikBjare commented 6 years ago

See my attempt at switching to persist-queue here: https://github.com/ActivityWatch/aw-client/pull/28

ErikBjare commented 6 years ago

Downgrading priority since we merged the persist-queue PR.

johan-bjareholt commented 6 years ago

All problems specified in the issue are now fixed, why not close this issue? If we find some other place where aw-client is not resilient enough we could create a new issue for that.

ErikBjare commented 6 years ago

Oh, I guess it is. Closing :smile: