ActivityWatch / activitywatch

The best free and open-source automated time tracker. Cross-platform, extensible, privacy-focused.
https://activitywatch.net/
Mozilla Public License 2.0
11.73k stars 533 forks source link

pyproject.toml build-system should use poetry-core instead of poetry #830

Closed huantianad closed 1 year ago

huantianad commented 1 year ago

Issue

The python packages that this project uses all use poetry's build system, and thus all have something like

[build-system]
requires = ["poetry>=0.12"]
build-backend = "poetry.masonry.api"

in their pyproject.toml files, which allows the packages to be built via a PEP517 frontend. However, we should instead depend on poetry-core instead of poetry in the build-system section, as we don't need the CLI tools of poetry to build the package, just the build system.

[build-system]
requires = ["poetry-core"]
build-backend = "poetry.core.masonry.api"

Should be used instead.

See https://github.com/python-poetry/poetry-core#why-is-this-required for more info.

github-actions[bot] commented 1 year ago

Hi there! As you're new to this repo, please make sure you've used an appropriate issue template and searched for duplicates (it helps us focus on actual development!). We'd also like to suggest that you read our contribution guidelines and our code of conduct. Thanks a bunch for opening your first issue! 🙏

johan-bjareholt commented 1 year ago

@ErikBjare Anything stopping us to just take in all these patches?

ErikBjare commented 1 year ago

Nope, going through them now :)

ErikBjare commented 1 year ago

All merged! Thanks @huantianad! ❤️