Sunburst clock can't show the whole 24-hour-event when 'start of day' in settings set anyvalue except 00:00

ActivityWatch / activitywatch

The best free and open-source automated time tracker. Cross-platform, extensible, privacy-focused.

https://activitywatch.net/

Mozilla Public License 2.0

11.73k stars 533 forks source link

Sunburst clock can't show the whole 24-hour-event when 'start of day' in settings set anyvalue except 00:00 #875

Closed szh-bash closed 9 months ago

szh-bash commented 1 year ago

[x] I am on the latest ActivityWatch version.
[x] I have searched the issues of this repo and believe that this is not a duplicate.

OS name and version: win11-22h2 pro
ActivityWatch version: 0.4.3

Describe the bug

It seems like AW choose to show the event between 'start of day' and midnight(24:00) in Sunburst clock which can be choosen to display in Summary.

I think it would be better if it could show [start, start+24h) as we do in live 24 hours a day, right?

To Reproduce

Go to settings
Set 'start of day' any value except 00:00, such as 04:00

Expected behavior

Documentation

Additional context

github-actions[bot] commented 1 year ago

Hi there! As you're new to this repo, please make sure you've used an appropriate issue template and searched for duplicates (it helps us focus on actual development!). We'd also like to suggest that you read our contribution guidelines and our code of conduct. Thanks a bunch for opening your first issue! 🙏

szh-bash commented 1 year ago

https://github.com/ActivityWatch/activitywatch/issues/508#issuecomment-753478789 it seems like 0:00 bug still exists so far @ErikBjare

BelKed commented 1 year ago

If the bug still exists, why are you opening a duplicate issue?

szh-bash commented 1 year ago

opening a duplicate issue?

I don't get it. If you were asking why i opened this issue, I found all the other relevant issue in this repo closed so i make a new one

BelKed commented 1 year ago

Oh, sorry, my bad...

I've thought the issue you mentioned was open. GitHub app doesn't have that much clear UI...

But, there still exists an opened issue: https://github.com/ActivityWatch/aw-webui/issues/358

szh-bash commented 1 year ago

Oh, sorry, my bad...

I've thought the issue you mentioned was open. GitHub app doesn't have that much clear UI...

But, there still exists an opened issue: ActivityWatch/aw-webui#358

you reopened it 44mins ago, i post this issue 2hours ago...nvm, just forget about it

BelKed commented 1 year ago

I closed it because I thought the mentioned issue was opened, so mine would also be a duplicate. And, when you've written that the issue isn't opened, I've also reopened mine.

szh-bash commented 1 year ago

I closed it because I thought the mentioned issue was opened, so mine would also be a duplicate. And, when you've written that the issue isn't opened, I've also reopened mine.

Sorry i misread and i didn't think about searching issues in other repos so didn't find yours at first.

But it's already 8 months, maybe it's time to post this new issue?

BelKed commented 1 year ago

That's fine :)

And I highly doubt that opening another issue would speed up the process of fixing the problem :D But feel free to do what you think is right :)