ErikBjare commented 3 years ago

I've had this in my working tree for a while. Should be improved behavior better aligned with how aw-server-rust works. Will hopefully fix https://github.com/ActivityWatch/activitywatch/issues/626.

(Needs thorough review, long time since I wrote this, and can't remember what I've done)

codecov[bot] commented 3 years ago

Codecov Report

Merging #105 (0b47c01) into master (efd1325) will decrease coverage by 0.62%. The diff coverage is 69.56%.

@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
- Coverage   90.78%   90.16%   -0.63%     
==========================================
  Files          34       34              
  Lines        1660     1687      +27     
  Branches      257      262       +5     
==========================================
+ Hits         1507     1521      +14     
- Misses        118      131      +13     
  Partials       35       35

Impacted Files	Coverage Δ
aw_transform/flood.py	`75.71% <69.56%> (-14.99%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update efd1325...0b47c01. Read the comment docs.

ErikBjare commented 2 years ago

Since this is based on the aw-server-rust implementation, I just want to note that it might not be without issues either: https://github.com/ActivityWatch/activitywatch/issues/602

ActivityWatch / aw-core

fix: refactored flood to better behavior #105

Codecov Report