moved from Pipfile/setup.py/pipenv to pyproject.toml/poetry

[lgtm-com[bot]]

This pull request fixes 1 alert when merging e75135566b8be4482853ae91ca3b4b428245b3ae into f6bcbd9551da124b76b478fe24bcb3a657d3789b - view on LGTM.com

fixed alerts:

• 1 for Unused import

[lgtm-com[bot]]

This pull request fixes 1 alert when merging f3e5c3b516605ca84ee851e30a884505f44726a1 into f6bcbd9551da124b76b478fe24bcb3a657d3789b - view on LGTM.com

fixed alerts:

• 1 for Unused import

[codecov[bot]]

Codecov Report

Merging #85 into master will decrease coverage by 4.23%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
- Coverage   95.01%   90.78%   -4.24%     
==========================================
  Files          34       34              
  Lines        1606     1606              
  Branches      249      249              
==========================================
- Hits         1526     1458      -68     
- Misses         44      113      +69     
+ Partials       36       35       -1

Impacted Files	Coverage Δ
aw_core/models.py	94.66% <100%> (ø)	:arrow_up:
aw_datastore/storages/mongodb.py	25.8% <0%> (-72.05%)	:arrow_down:
aw_datastore/__init__.py	92.3% <0%> (-7.7%)	:arrow_down:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f6bcbd9...c5e9d34. Read the comment docs.

[lgtm-com[bot]]

This pull request fixes 1 alert when merging c5e9d34daf30a2c662ef083804affd499414597f into f6bcbd9551da124b76b478fe24bcb3a657d3789b - view on LGTM.com

fixed alerts:

• 1 for Unused import

[johan-bjareholt]

You forgot to update the Makefiles!!!

[ErikBjare]

@johan-bjareholt Uh no? pip supports pyproject.toml for non-dev installation.

[johan-bjareholt]

@ErikBjare Oh, I was trying to install with DEV=1 and it didn't work so I assumed that it's broken.

So if i understand things corrently, now we lost support for --editable and "setup.py develop" so we're required to either install every time we change something or use an virtualenv?

[ErikBjare]

Huh, I didn't know that --editable had broken, I'll look into it.

poetry install will set up a virtualenv and install the package as editable.

[ErikBjare]

Alright, I should have fixed it in https://github.com/ActivityWatch/aw-core/commit/4f4b4b241d2d9873c85af81be30ad2770d0d1fc0. The solution was simply to opt for using poetry install over pip3 install when DEV is set.

Apparently --editable isn't supported by PEP0517 so pyproject.toml can't support it, but since poetry install does the equivalent by default we should simply opt for using it in case we're installing for development purposes.

[ErikBjare]

Working on fixing the other packages as well btw