search

ActivityWatch / aw-core

Core library for ActivityWatch
Mozilla Public License 2.0
48 stars 46 forks source link

test: added test for intersecting eventpairs #94

Closed ErikBjare closed 4 years ago

ErikBjare commented 4 years ago

The intersection check I made in https://github.com/ActivityWatch/aw-client/pull/50 doesn't work, leading me to believe there is a bug in _intersecting_eventpairs.

I can't figure out what is causing it, here's what I tried to reproduce in tests.

codecov[bot] commented 4 years ago

Codecov Report

Merging #94 into master will increase coverage by 0.26%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
+ Coverage   90.66%   90.92%   +0.26%     
==========================================
  Files          34       34              
  Lines        1606     1608       +2     
  Branches      249      251       +2     
==========================================
+ Hits         1456     1462       +6     
+ Misses        115      112       -3     
+ Partials       35       34       -1
Impacted Files Coverage Δ
aw_transform/filter_period_intersect.py 91.95% <100.00%> (+2.54%) :arrow_up:
aw_datastore/__init__.py 92.30% <0.00%> (+15.38%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 548f4fc...0a82778. Read the comment docs.

ErikBjare commented 4 years ago

lol, was simply a matter of not sorting input lists.