ActivityWatch / aw-qt

Tray icon that manages ActivityWatch processes, built with Qt.
Mozilla Public License 2.0
27 stars 29 forks source link

Only disable console on Windows #31

Closed ErikBjare closed 6 years ago

ErikBjare commented 6 years ago

This needs to be tested properly before merging since it turns out that console=False has some implications that might break stuff unexpectedly.

Also, having the console show up is really useful when debugging (or just when users come across unexpected behaviors, which still happens from time to time). The preferable thing would be to give the executable a parameter to hide/show the console. (See https://github.com/pyinstaller/pyinstaller/issues/2117 and https://github.com/pyinstaller/pyinstaller/issues/1339#issuecomment-122909830)

johan-bjareholt commented 6 years ago

Also, having the console show up is really useful when debugging (or just when users come across unexpected behaviors, which still happens from time to time). The preferable thing would be to give the executable a parameter to hide/show the console.

Isn't there some way to just tee stdout and stderr to a file? Would be a lot easier.

ErikBjare commented 6 years ago

We might just want to go ahead and merge this after adding a simple platform check for windows.

ErikBjare commented 6 years ago

Looks like had already added that check, merging.