Run tray icon generation only when systray available.

ActivityWatch / aw-qt

Tray icon that manages ActivityWatch processes, built with Qt.

Mozilla Public License 2.0

27 stars 29 forks source link

Run tray icon generation only when systray available. #40

Closed Bass-03 closed 1 year ago

Bass-03 commented 5 years ago

Got annoyed by this pop up error on POP_os 18.04. Should happen on ubuntu > 17.04 or any gnome 3 distro.

Run code only when systray is available instead of showing an error.

Now I can run aw-qt on startup with no issues.

ErikBjare commented 5 years ago

Thanks for the PR!

I'm a bit concerned however about the UX for the users where a systray isn't available since it gives a differing experience (although that's better than not working at all, lol). Preferably we'd just implement support for appindicators as discussed in https://github.com/ActivityWatch/activitywatch/issues/238 but this might be a good alternative for now.

What do you think @johan-bjareholt?

johan-bjareholt commented 4 years ago

It now also seems like upstream gnome itself has removed support for appindicators as well. However, Ubuntu and a few other distros seem to ship with an extension by default which allows them.

ErikBjare commented 1 year ago

I've recently added a --no-gui option in https://github.com/ActivityWatch/aw-qt/commit/744c8d25b806324a5dd59a0b7652d5aa9cac0f31 that doesn't initialize the trayicon at all.

Kinda makes this PR redundant, so closing.

Thanks for contributing!