search

ActivityWatch / aw-qt

Tray icon that manages ActivityWatch processes, built with Qt.
Mozilla Public License 2.0
27 stars 29 forks source link

[macOS] removes python-rocket from dock if pyobjc is installed #42

Closed exoji2e closed 5 years ago

exoji2e commented 5 years ago

Tries to disable the dock icon, when aw-qt is launched on macOS.

However I only found a solution with AppKit (python3 -m pip install pyobjc), which is a macos-only package. Instead of including it in a setup script, I just catch the import error. Not the nicest solution, but it works. When writing the documentation about auto starting on macOS we should add this information.

johan-bjareholt commented 5 years ago

Instead of including it in a setup script, I just catch the import error. Not the nicest solution, but it works. When writing the documentation about auto starting on macOS we should add this information.

It's easier if you simply check for "Darwin" in the setup.py script and append the package to the dependencies then so the user doesn't need any manual steps to install dependencies.

Otherwise it looks good!

exoji2e commented 5 years ago

Makes sense. Fixed it, and removed old commit.

johan-bjareholt commented 5 years ago

@ErikBjare Can we merge this now?

ErikBjare commented 5 years ago

Yeah, minor codestyle complaints but whatever. Merging.