Let trayicon owning program handle coloring it with filters

ActivityWatch / aw-qt

Tray icon that manages ActivityWatch processes, built with Qt.

Mozilla Public License 2.0

27 stars 28 forks source link

Let trayicon owning program handle coloring it with filters #57

Closed xylix closed 4 years ago

xylix commented 4 years ago

Fixes https://github.com/ActivityWatch/activitywatch/issues/358 @ErikBjare I think this can be merged.

ErikBjare commented 4 years ago

Don't forget to remove the now-unused image :)

xylix commented 4 years ago

Oh yeah. Did that here https://github.com/ActivityWatch/media/pull/2 . Will need that merged so I can update the submodule here.

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging d5102b0ea024176c76f63ddc76c7ddc02b92ae68 into 91f250b8235efaa2fb53b75ba0570c2b5ab6336e - view on LGTM.com

new alerts:

1 for Unused local variable

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging 7f3647bbd8b59c58080a53c691ed6b7c9ece6329 into 91f250b8235efaa2fb53b75ba0570c2b5ab6336e - view on LGTM.com

new alerts:

1 for Unused local variable

ErikBjare commented 4 years ago

Sorry for the delay. Merged the other PR now.

Did you test it by changing the system theme while running?

xylix commented 4 years ago

I did test it by changing system theme while it was running, and it worked for me on macOS catalina. (the icon changed color as expected)

ErikBjare commented 4 years ago

Nice, merging!