Update to using the latest aw-client

ActivityWatch / aw-watcher-vscode

Mozilla Public License 2.0

186 stars 26 forks source link

Update to using the latest aw-client #6

Closed devzsolt closed 5 years ago

devzsolt commented 5 years ago

This changeset contains several small changes:

update submodules aw-client-js and media to latest
fix the extension to work with the latest aw-client:
- AppEditorActivityHeartbeat --> AppEditorEvent
- createBucket --> ensureBucket
- options object in AWClient constructor
- timestamp should be a Date not a string
fix lint error in catch of _sendHeartbeat
restore _getProjectName() to populate field projectName (I liked the previous logic better so restored it into a new field keeping project intact logging the project path)
also includes my previous PR #5

Otto-AA commented 5 years ago

Thanks for your contribution, it seems fine to me :+1: I haven't installed activitywatch since my last computer reset, so I can't test it, but from the logic it seems nice.

Regarding merging and publishing via vsce, I guess it would be better if someone else becomes the maintainer of this watcher. I myself sadly don't have time for maintaining, testing new pull requests, finding bugs, etc. anymore, so I would suggest to find a new maintainer or mark it as unmaintained. @johan-bjareholt

And here is the discussion about the format if you want to read it: https://forum.activitywatch.net/t/bucket-and-event-design-fo-vs-code-extension/120/9

johan-bjareholt commented 5 years ago

@Otto-AA Alright, I guess that I can take up the maintainership until we find a better maintainer I guess then. I'm not using vscode on a daily basis, but I feel comfortable with the code so it'll do.

Otto-AA commented 5 years ago

@johan-bjareholt Is your email address from github still correct? If yes, I will give you owner rights for the extension (for publishing via vsce)

johan-bjareholt commented 5 years ago

@Otto-AA Yes that is still my mail, that'll work fine.

Also, I tested the code and everything seems to work fine

johan-bjareholt commented 5 years ago

I'll merge this, fix the comment I made and add it to the ChangeLog because I'm likely not going to have time to review this later in the week.

johan-bjareholt commented 5 years ago

@devzsolt Thanks for the PR by the way! :smiley:

devzsolt commented 5 years ago

@johan-bjareholt @Otto-AA you're welcome. Sorry that I didn't follow the conversation. I'm glad that you have found my PRs useful. I'm using it for almost a week now and works well. Thank you for developing this extension in the first place!

Thanks for explaining why you discarded the project name idea. I'm not sure yet if I'll ever use it but in the future I'm thinking about some pattern based categorization and a simplified custom visualization. Of course the full path is unique for pattern matching and possibly the patterns would have a metadata containing the project name (which I would enter once manually)... so you're right, it's possibly useless data :)

ErikBjare commented 5 years ago

@devzsolt If you're interested in categorizing activity using pattern-matching, check out my work in aw-research here: https://github.com/ActivityWatch/aw-research/pull/12

And the general issue on the matter: https://github.com/ActivityWatch/activitywatch/issues/95