ActivityWatch / aw-watcher-window

Cross-platform window watcher (for use with ActivityWatch)
Mozilla Public License 2.0
90 stars 53 forks source link

feat: added back wmi method on Windows as fallback for admin processes #96

Closed ErikBjare closed 10 months ago

ErikBjare commented 11 months ago

I haven't tested this or anything, flying blind on a non-Windows machine, but shouldn't be much more than this.

Addresses regression caused by https://github.com/ActivityWatch/aw-watcher-window/pull/83

Fixes #94 Fixes https://github.com/ActivityWatch/activitywatch/issues/873 Fixes https://github.com/ActivityWatch/activitywatch/issues/1004

ErikBjare commented 10 months ago

As I wrote in https://github.com/ActivityWatch/activitywatch/issues/1004:

Might be bold and merge this without testing it myself. Goal is to get a new beta release out that fixes this ASAP (along with another window watcher fix for macOS).

vasiliy-pdk commented 6 months ago

Thanks for the fix! 👍 I am eager to test it to fix Helldivers 2 tracking information missing https://github.com/ActivityWatch/activitywatch/issues/1029

Not sure how to test it though. I found this release https://github.com/ActivityWatch/activitywatch/releases/tag/v0.12.3b16 that includes the commits from this branch but there's a warning saying that the release is broken on several platforms. I checked the freshest beta release and found no commits from this branch.

Was it reverted or there's another fix elsewhere?

ErikBjare commented 6 months ago

@vasiliy-pdk Try a newer beta than v0.12.3b16.

The commit won't show up in the commit history you linked, since the change happened in a submodule. But it is included in the release notes for v0.12.3b16, which are generated including submodules.

vasiliy-pdk commented 6 months ago

Thanks! Installed the most recent beta 12.3b.19 release and can track Helldivers 2 now.

Screenshot 2024-05-23 204731