search

ActivityWatch / aw-webui

Webapp for visualizing and browsing ActivityWatch data, built with Vue.js.
Mozilla Public License 2.0
105 stars 108 forks source link

fix: fixes bug in category builder when word 'constructor' exists #564

Closed ErikBjare closed 5 months ago

ErikBjare commented 5 months ago

Fixes https://github.com/ActivityWatch/activitywatch/issues/1054

:rocket: This description was created by Ellipsis for commit 6d10c192e074ea4ffb17031980a5681be0a604df

Summary:

This PR fixes a bug in CategoryBuilder.vue by changing the storage of words from an object to a Map, ensuring all words, including JavaScript property names like 'constructor', are treated uniformly.

Key points:

Generated with :heart: by ellipsis.dev

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 25.60%. Comparing base (dd37252) to head (6d10c19).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #564 +/- ## ======================================= Coverage 25.60% 25.60% ======================================= Files 27 27 Lines 1613 1613 Branches 281 273 -8 ======================================= Hits 413 413 - Misses 1141 1174 +33 + Partials 59 26 -33 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ErikBjare commented 5 months ago

Ah right, dang it.

Made the change in https://github.com/ActivityWatch/aw-webui/pull/565, not sure if it's finally correct as I haven't tested.