fix: hopefully actually fixes bug in category builder for 'constructor' word (and other prototype stuff)

ActivityWatch / aw-webui

Webapp for visualizing and browsing ActivityWatch data, built with Vue.js.

Mozilla Public License 2.0

105 stars 108 forks source link

fix: hopefully actually fixes bug in category builder for 'constructor' word (and other prototype stuff) #565

Closed ErikBjare closed 4 months ago

ErikBjare commented 5 months ago

Follow up on https://github.com/ActivityWatch/aw-webui/pull/564

:rocket: This description was created by Ellipsis for commit b5e9eb076de836d10421de37531a98540c025de5

Summary:

Updated CategoryBuilder.vue to use Map for storing words, replacing object structure to handle prototype-related issues correctly.

Key points:

Changed data structure for storing words from object to Map in CategoryBuilder.vue.
Replaced in keyword with Map methods (has, get, set) to avoid prototype pollution.
Ensures words like 'constructor' are handled correctly.

Generated with :heart: by ellipsis.dev

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 25.60%. Comparing base (cb83d12) to head (b5e9eb0).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #565 +/- ## ======================================= Coverage 25.60% 25.60% ======================================= Files 27 27 Lines 1613 1613 Branches 286 286 ======================================= Hits 413 413 - Misses 1141 1174 +33 + Partials 59 26 -33 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ErikBjare commented 4 months ago

@john30 Haven't tested (again), but I think this should be correct now.

ErikBjare commented 4 months ago

@BelKed fixed in https://github.com/ActivityWatch/aw-webui/pull/569

just out of curiosity: why do you push and merge immediately before anyone had the chance to review it?

Eagerness, clearly to a fault in this case. Sorry about that. Was juggling many PRs and was hoping to get this one over with.