ActivityWatch / aw-webui

Webapp for visualizing and browsing ActivityWatch data, built with Vue.js.
Mozilla Public License 2.0
105 stars 108 forks source link

fix: correctly invert colors of alerts in dark mode #591

Closed BelKed closed 2 months ago

BelKed commented 3 months ago

Before:

Screenshot


After:

Screenshot


:rocket: This description was created by Ellipsis for commit 67db254af716ca4d584056430078dd5c194f84ba

Summary:

Exclude the close button from color changes in dark mode by updating static/dark.css.

Key points:


Generated with :heart: by ellipsis.dev

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 26.13%. Comparing base (2f3d1e8) to head (275a2e6). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #591 +/- ## ======================================= Coverage 26.13% 26.13% ======================================= Files 27 27 Lines 1630 1630 Branches 281 286 +5 ======================================= Hits 426 426 - Misses 1145 1178 +33 + Partials 59 26 -33 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ErikBjare commented 2 months ago

This is great, but I wonder if we should instead make the popup less bright/a darker red (and a brighter text).

BelKed commented 2 months ago

Good point, "inverting" the colors makes it look amazing 😍

Screenshot 2024-07-10 at 13 26 26 Screenshot 2024-07-10 at 13 26 46 Screenshot 2024-07-10 at 13 26 08

ErikBjare commented 2 months ago

Very nice! Merging :tada: