search

ActualMandM / gfx_pack

WIP version 5 graphic packs
https://github.com/slashiee/cemu_graphic_packs
Creative Commons Zero v1.0 Universal
0 stars 0 forks source link

Issues with Breath of the Wild Graphic Packs #7

Closed Crementif closed 6 years ago

Crementif commented 6 years ago

Feel free to help us by commenting newly found issues if you find any. If it's at a specific point in the game (like a final boss or something), providing a save file will help.

Currently known issues:

Crementif commented 6 years ago

Just moving the appreciated feedback from @getdls here.

Not sure if you want any input on this yet?

Shrine light sources/lamps and bloom are broken.. not sure where it goes wrong without poking around, but I'm guessing a 640 scaling?

Duplicate

[TextureRedefine] # Depth Map 2
width = 320
height = 180
formats = 0x001
overwriteWidth = ($width/$gameWidth) * 320
overwriteHeight = ($height/$gameHeight) * 180

# Fix Shadows
[TextureRedefine] # Depth Map 2
width = 320
height = 180
formats = 0x001
overwriteWidth = ($width/$gameWidth) * 320
overwriteHeight = ($height/$gameHeight) * 180

0x816 isn't scaled but used for bloom/blur pyramids starting with 320 and going down.. It's been a while but from what I remember we had to scale all of the 320x formats in the end to get both depth and bloom to work with heat haze. 

[TextureRedefine] # Bloom
width = 320
height = 180   and 192
overwriteWidth = ($width/$gameWidth) * 320
overwriteHeight = ($height/$gameHeight) * 180
getdls commented 6 years ago

The attached rules "passes" most of the wake-up link intro. Bloom is scaled (first 3 levels at least) , light sources and cinematic DOF. There are rules in place for the rest of the bloom/depth , but they need separate verification so they don't break other stuff. esp all the cube/light grading

Missing light was due to 512x256 rule.

BreathOfTheWild.zip

Also spent waay too long time before I figured out that the "fog" of the opening scene is broken due to cemu, not gfx pack.. It looks like we can't exclude 0x01a without breaking up-scaling. The original pack had that as a rule.

Crementif commented 6 years ago

Hm, I've already found out some of the issues above (like the bloom). Haven't look at the link intro yet, so I'll add those related lines.

Interesting to see it use the old pack or some new implementation by you.

Crementif commented 6 years ago

This issue has become pretty outdated since SkalFate took BotW over. None of the problems mentioned are a problem anymore. But, if there's any more problems in the future or need for a thread, should make a new thread anyways.