ActualMasterOogway / Fluent-Renewed

An edited version of Fluent, a Roblox UI Library. This fixes various Bugs that were in the original Version and also gets updated frequently with new features.
MIT License
4 stars 5 forks source link

Dropdown.SetValues causes stuttering/fps drops #13

Open ATrainz opened 2 weeks ago

ATrainz commented 2 weeks ago

When using dropdowns to select a player, I change the values everytime a player is added or a player leaves,

The problem is when you do Options.MyDropdown:SetValues(Players:GetPlayers()) everytime a player is added or leaves it stutters for a second

This got annoying after a while so I had to scrap the dropdown and used a keybind and the closest player to mouse instead (I don't really like it though)

A fix is to either optimize the dropdown or add a new element/setting for Player Dropdowns Example:

MyTab:CreatePlayerDropdown("AllPlayers", {
    Title = "Target",
    Multi = false,
    IncludeLocalPlayer = true,
    DisplayNames = false, -- whether or not it uses the players display names for the dropdown
    Default = game:GetService("Players").LocalPlayer
})
ActualMasterOogway commented 2 weeks ago

Hi there,

I have no idea why its stuttering when calling Dropdown:SetValues. Therefore I probably won't be able to fix this anytime soon. I'll make sure to implement custom "Player Dropdowns" in later updates.

Best Regards, Oogway

ActualMasterOogway commented 2 weeks ago

I hope someone will someday make a PR that fixes this issue. 😶

ATrainz commented 2 weeks ago

Hi there,

I have no idea why its stuttering when calling Dropdown:SetValues. Therefore I probably won't be able to fix this anytime soon. I'll make sure to implement custom "Player Dropdowns" in later updates.

Best Regards, Oogway

I see, I'm not too good at scripting or optimizing so I don't know how to fix it either (still learning) Thank you for your time and making quick updates Master Oogway