Closed Pat-Reen closed 2 years ago
Hi @Pat-Reen,
Thank you for the contribution.
Some minor issues picking up from review:
[Data description](Framingham Longitudinal Data Documentation.pdf)
isn't showing up as a link. Is the pdf copyright available?Another general q's I had: How are you getting NN's to do well on sparse data vs GBDT?
I also just want to say it's really cool to see MCMC and R XGBoost on the cookbook.
Thanks Jacky for review. I have made some changes to the Tree model section and will rephrase the description. Agree that xgboost is an improved algorithm of GBDT.
I haven't spent too much time on training life data using NN and the preliminary result was worse than tree models. I would expect NN requires dense data and large dataset to work well. I will speak to Pat about this and see if we can add something.
Replaced by pull request #36. Addresses the feedback from @JackyP.
I have updated. Replaced with PR #36.
On Tue, 15 Mar 2022, 11:41 am Patrick Reen, @.***> wrote:
Thanks both. I owe you some edits as well. Will get to in soon. Thanks!
On Tue, 15 Mar 2022, 9:03 am Charlie, @.***> wrote:
Thanks Jackie for review. I have made some changes to the Tree model section and will rephrase the description. Agree that xgboost is an improved algorithm of GBDT.
I haven't spent too much time on training life data using NN and the preliminary result was worse than tree models. I would expect NN requires dense data and large dataset to work well. I will speak to Pat about this and see if we can add something.
— Reply to this email directly, view it on GitHub https://github.com/ActuariesInstitute/cookbook/pull/32#issuecomment-1067346731, or unsubscribe https://github.com/notifications/unsubscribe-auth/AV2VKIH4XGGCC2QYPOZXNCDU76ZUTANCNFSM5NQVDHKA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID: @.***>
Thanks both. I owe you some edits as well. Will get to in soon. Thanks!
On Tue, 15 Mar 2022, 9:03 am Charlie, @.***> wrote:
Thanks Jackie for review. I have made some changes to the Tree model section and will rephrase the description. Agree that xgboost is an improved algorithm of GBDT.
I haven't spent too much time on training life data using NN and the preliminary result was worse than tree models. I would expect NN requires dense data and large dataset to work well. I will speak to Pat about this and see if we can add something.
— Reply to this email directly, view it on GitHub https://github.com/ActuariesInstitute/cookbook/pull/32#issuecomment-1067346731, or unsubscribe https://github.com/notifications/unsubscribe-auth/AV2VKIH4XGGCC2QYPOZXNCDU76ZUTANCNFSM5NQVDHKA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID: @.***>
Adding in subsections on decision trees and bayesian applications.