AcutronicRobotics / HRIM

An information model for robot hardware. Facilitates interoperability across modules from different robot manufacturers. Built around ROS 2.0
https://acutronicrobotics.com/technology/hrim/
Apache License 2.0
66 stars 22 forks source link

Updown service #63

Closed ibaiape closed 5 years ago

ibaiape commented 5 years ago

Added optional generic service for component shutdown/power up called UpDown with the following content:

bool power_on # whether the device should be powered on or not
---
bool result # whether the order was successfully carried out or not
string error_message # text message describing issues when carrying out the power on/off order

Feedback on the service naming is appreciated, as:

Restructured the generic interfaces' model folders to homogenize with the rest of models.

Separated into a file (generic.xml) containing all generic interfaces for generation and another (base.xml) to group the generic mandatory interfaces (like before).

ahcorde commented 5 years ago

I don't really like the service name UpDown, it's rather confusing.

I would suggest something like:

@ibaiape, @carlossvg, @igorrecioh suggestions are wellcome.

igorrecioh commented 5 years ago

I have a doubt, the idea of this service is only for switching the component off or also for turning it on? If its aim is to switch off, I would choose Shutdown