search

AcutronicRobotics / moveit2

The MoveIt 2 Motion Planning Framework for ROS 2.0
BSD 3-Clause "New" or "Revised" License
54 stars 17 forks source link

Visualization port #101

Closed nzlz closed 5 years ago

nzlz commented 5 years ago

Description

Porting moveit_rviz_plugin_render_tools inside moveit_ros/visualization. The goal of the PR is to save/backup the branch in the Acutronic repo instead of my personal one.

ahcorde commented 5 years ago

I resolved the conflicts to be able to merge it into master. @nzlz can you check that I didn't remove something relevant?

nzlz commented 5 years ago

Compiling fine (only warnings) after latest move_group fixes. https://github.com/AcutronicRobotics/moveit2/pull/103#issuecomment-499345678 .

Ready to merge in the visualization branch IMHO.

anasarrak commented 5 years ago

It seems like moveit_ros_visualization is not passing the CI 

Summary: 35 packages finished [18min 21s]
  1 package failed: moveit_ros_visualization
  1 package aborted: moveit_ros_manipulation
LanderU commented 5 years ago

I'm working to fix the CI to have this and other PR merged ASAP.

nzlz commented 5 years ago

The port of motion_planning_rviz_plugin will be long and complex. You can take a look at the unported dependencies here: https://github.com/nzlz/moveit2/tree/visualization/moveit_ros/visualization#motion_planning_rviz_plugin-unported-dependencies

I'll dive into these issues and see the feasibility of the migration and plan how to proceed, but input is welcomed.

LanderU commented 5 years ago

CI passed!

nzlz commented 5 years ago

Great! Can we merge and start working in the acutronic repo (visulization branch)?

LanderU commented 5 years ago

@ahcorde @anasarrak, review it this again.

nzlz commented 5 years ago

@anasarrak the motion planning plugin you are referring to is not ported to ros2. Reason : https://github.com/nzlz/moveit2/tree/visualization/moveit_ros/visualization#motion_planning_rviz_plugin-unported-dependencies

Do you want to fix those before merge anyway?

anasarrak commented 5 years ago

@nzlz and I have discussed about the motion_planning_rviz_plugin, taking into account that the plugin is not ported and needs further work, we haved decided to leave it as master, and create a branch with the current work, so the changes are not lost. There are many changes that needs to be reviewed and right now because of https://github.com/AcutronicRobotics/moveit2/pull/101#issuecomment-501151147 we cannot reproduce it. What's your opinion about that @ahcorde ?

motion_planning_rviz_plugin is the only one that is not ported, the remaining ones should be ported.

anasarrak commented 5 years ago

Lets wait the CI, if it passes we can merge this

nzlz commented 5 years ago

Updated.

anasarrak commented 5 years ago

I cherry-picked the changes for the CI

ahcorde commented 5 years ago

Let's wait for the CI again

nzlz commented 5 years ago

Ping, CI passing.

vmayoral commented 5 years ago

What's up with this guys?

anasarrak commented 5 years ago

This can be merged, waiting for @ahcorde's approval