Ad5001 / BetterGen

PocketMine's Tomorrow's World Generator. Mirror of
https://git.ad5001.eu/Ad5001/BetterGen
Other
58 stars 27 forks source link

Switching to Minecraft PC Loot tables #10

Open Thunder33345 opened 7 years ago

Thunder33345 commented 7 years ago

Basically title; having a similar or same system as mojang current loot table works

The conditions section could get ignored but some basics would be nice

wiki: http://minecraft.gamepedia.com/Loot_table#Tags

low priority but good to take note of and sorted when other higher things get done

inxomnyaa commented 7 years ago

https://github.com/ClearSkyTeam/PocketMine-MP/commit/6ef9e616f9b14a8eff1155e567725d85af9ebadf

Loot table generation/randomisation proven to work here.

This could be imported to this plugin.

Thunder33345 commented 7 years ago

Table gen: https://github.com/ClearSkyTeam/PocketMine-MP/blob/6ef9e616f9b14a8eff1155e567725d85af9ebadf/src/pocketmine/utils/TempLootGenerator.php loot tables: https://github.com/ClearSkyTeam/PocketMine-MP/blob/6ef9e616f9b14a8eff1155e567725d85af9ebadf/src/pocketmine/resources/loot_tables/gameplay/fishing.json https://github.com/ClearSkyTeam/PocketMine-MP/blob/6ef9e616f9b14a8eff1155e567725d85af9ebadf/src/pocketmine/resources/loot_tables/gameplay/fishing/fish.json https://github.com/ClearSkyTeam/PocketMine-MP/blob/6ef9e616f9b14a8eff1155e567725d85af9ebadf/src/pocketmine/resources/loot_tables/gameplay/fishing/junk.json

inxomnyaa commented 7 years ago

Those loot tables are actually taken from the MCPE default addon.

Ad5001 commented 7 years ago

Btw am I allowed to take this code and adapt it or not?

inxomnyaa commented 7 years ago

This could be imported to this plugin

Thunder33345 commented 7 years ago

Btw am I allowed to take this code and adapt it or not?

i dont see anything stopping you like it's already open sourced but i advise you not to copy it directly due to how it's meant only for fishing with bunch of hotfixes love the usage of projects FINALLY... Someone used it

Ad5001 commented 7 years ago

They are pretty useful by using issues ;)

inxomnyaa commented 7 years ago

cough assign me

Ad5001 commented 7 years ago

@thebigsmileXD Well, I can't until you accept the colaboration.

inxomnyaa commented 7 years ago

Oh xd i forgot that this is needed

Ad5001 commented 7 years ago

@thebigsmileXD Btw when you start working on an issue, Move it in the projects tab ;)

inxomnyaa commented 7 years ago

kk

inxomnyaa commented 7 years ago

image

inxomnyaa commented 7 years ago

image See the loottables branch

Thunder33345 commented 7 years ago

try to close only after it's merged pull #22 is not merged

inxomnyaa commented 7 years ago

the problem is the legal part eula and shit

inxomnyaa commented 7 years ago

image This might take some fucking time

inxomnyaa commented 7 years ago

Nope, fuck this. I will not go through every fucking file and remake all changes

@Ad5001 DIY.