Loottables

[inxomnyaa]

Chests 100% generated from loottables. Uses a MCPE default addon as submodule (poggit dependency update maybe? idk how poggit actually functions)

This also fixes where the chests are placed and their rotation ( in temples) adding new variants is easy AF.

[Ad5001]

Can this be merged?

[inxomnyaa]

i talked to @dktapps and looks like there are legal issues.. we could ignore them for now and say, hey mojang, the addons are open source anyways. otherwise.. it could be made an external link instead.

[inxomnyaa]

So, i leave the decision to you ;) i'd say yes

[Ad5001]

They didn't specify any LICENSE. And the problem is that all rights are reserved to the author in case of no LICENSE. + The truth of dependencies is they broke on download. It'd be better just to take the loot tables I believe.

[Thunder33345]

just edit the odds by 1% shouldnt that stops it?

[Ad5001]

@thebigsmileXD Two problems with submodules:

• Not cloning when downloading

• Adds useless things such as entity generation

• We can make a "special thanks" in the readme telling that we are not the copyright owners of content under /resources/loot_tables.

[Ad5001]

• You forgot something with your debug. It's executed sync whereas generation is async so we cannot spawn tiles. That's my main struggle.

[inxomnyaa]

thats why the main class comes in. AS SAID, this pushed the Legal thing to a NOPE

[Ad5001]

You haven't understood what I meant. Your "placeLootTable" method uses a pocketmine\level\Level instance to spawn a tile. In async, there is no pocketmine\level\Level. Just ChunkManagers which cannot spawn tiles.

[Ad5001]

And about the legal thing, I have to agree with you. But the github bug makes it absolutly unuser friendly.

[inxomnyaa]

There is no github bugs, there are simply users that are too noobish to git clone recursive..

You haven't understood what I meant. Your "placeLootTable" method uses a pocketmine\level\Level instance to spawn a tile. In async, there is no pocketmine\level\Level. Just ChunkManagers which cannot spawn tiles.

Wrong. it uses the ChunkManager, which is a Level class

[Ad5001]

There is not github bugs, there are simply users that are too noobish to git clone recursive..

Well, that means to download a simple plugin, you need to pass by git? Well, the common server owners don't know how to use git. They simply click the big "Download" button which is generated from an archive, which, doesn't apply submodules and transfer it to their server using a GUI such as Filezilla.

Wrong. it uses the ChunkManager, which is a Level class

https://github.com/pmmp/PocketMine-MP/blob/master/src/pocketmine/level/Level.php#L112 https://github.com/pmmp/PocketMine-MP/blob/master/src/pocketmine/level/SimpleChunkManager.php#L28 Level is a ChunkManager thought ChunkManager (in case of generation SimpleChunkManager) isn't a Level.

[Ad5001]

Btw why did you deleted this branch?

[inxomnyaa]

I deleted it because its not worth to get legal issues because someone here *cough you* doesn't understand what i am aiming at

[AvgZing]

Legal issues are the worst and they are always tough to resolve (hint, hint? Functions?)

[inxomnyaa]

My idea simply was to let the chests not generate anything inside, except when the user manually places an addon into a folder

[HimbeersaftLP]

What about asking Mojang vie Email if they allow you to use it :D

[Ad5001]

@thebigsmileXD You means it only generates when the users hits it? Then, just use the "processingLoots.json" file to gen id in async instead of using a none creatable tile ;). @HimbeersaftLP That's a good idea !

[inxomnyaa]

@HimbeersaftLP they don't. I did ask.

[inxomnyaa]

Btw why did you deleted this branch?

Because i hate it when i see someone that doesn't understand the code i made or what i say destroying my codechanges.