[Bug] Issue with trainer name lengths / encryption

AdAstra-LD / DS-Pokemon-Rom-Editor

New DS Pokemon ROM Editor, based on Nømura's 2020 edition. Expanded with loads of new features, bugfixes and better usability.

165 stars 45 forks source link

[Bug] Issue with trainer name lengths / encryption #25

Closed Mixone-FinallyHere closed 1 year ago

Mixone-FinallyHere commented 1 year ago

Investigating

Asparago:

basically when you change some trainers the name will become a mess and the fix is a simple hex edit of 1 byte in the arm9

Mixone-FinallyHere commented 1 year ago

This comment had data for issue 24 incorrectly

AdAstra-LD commented 1 year ago

Refined:

This error apparently existed in 1.8 though it does not cause a crash there It means that when scrolling from a small map to a large map you cannot "visit" all chunks of the new map because it uses the already loaded in smaller matrix for the larger map

wait, what does this have to do with the char name issue?

Mixone-FinallyHere commented 1 year ago

Thats my bad! That was meant to go on the maps one

Mixone-FinallyHere commented 1 year ago

Various ways to tackle this:

[ ] Encrypt back correctly => this should be happening as trainer names treated as a text archive unclear why it is not doing so
[x] Add checks to name length => names that are too long are not alerted, this needs fixing to anything above 12 chars anyway
[ ] Optimal solution is adding a change to max trainer name length => this involves editing an address in arm9 from 08 to 0C it should be simple but each version has different address so without an exhaustive list of ver+lang offsets or a smart way of checking this cannot be done

Mixone-FinallyHere commented 1 year ago

For now will be adding this, the compression issue needs some retouching of the text archive processing which id rather not mess with yet and add a quick fix for now

Mixone-FinallyHere commented 1 year ago

Will be closed and thematically change issue to be a feature