search

AdAstra-LD / DS-Pokemon-Rom-Editor

New DS Pokemon ROM Editor, based on Nømura's 2020 edition. Expanded with loads of new features, bugfixes and better usability.
165 stars 45 forks source link

Longer Trainer Names Patching #34

Closed Mixone-FinallyHere closed 11 months ago

Mixone-FinallyHere commented 1 year ago

Addresses #29 partially.

TODO:

Current max value set at 12.

Testing at 15 showed some errors likely due to still missing encryption.

a) Adds a check at start of Rom to see if lang is compatible. b) Adds a check at start to see if already performed. c) Adds a check when NOT patched and trainer name > 7 chars. d) Adds dialog to send to RomToolBox when c) e) Adds a check when trainer name > max value set

Only supports Eng and Spa for now. Some still need verifying:

// Pearl USA ARM9 at 0x6AC32 // TODO: Verify // Pearl Spain ARM9 at 0x6AC8E // TODO: Verify // SoulSilver Spain ARM9 at 0x7342E // TODO: Verify

Mixone-FinallyHere commented 1 year ago

@AdAstra-LD not sure why Resx and Designer keep having merge conflicts

I made no changes to mainwindow UI so its all typical bloat, seems like some IDs changed and they had to be merged but git thinks i made 2000 changes....