AdAway / AdAway

AdAway is a free and open source ad blocker for Android.
https://adaway.org
GNU General Public License v3.0
7.01k stars 569 forks source link

Update submodule jnis #1799

Open TacoTheDank opened 4 years ago

TacoTheDank commented 4 years ago

I think it'd be good to update these as well. I'd do it myself, but I don't want to risk messing anything up by accident.

PerfectSlayer commented 4 years ago

Hi @TacoTheDank !

Thanks for this idea. Mongoose is in version 6.10 from commit 5b0b45ef9bdfdeb48285929b3deaf89252067cd1 (You can find such info with git log --grep mongoose.)

The main ideas behind native update are:

If everything seems fine, I'll be glad to update 😉 Would you like to have a look at it?

TacoTheDank commented 4 years ago

I'll leave that to the people with more experience lol. I have no idea what files are necessary or not, nor what changes might have to be made on the Java side.

TacoTheDank commented 4 years ago

The latest NDK right now is r21b https://developer.android.com/ndk/downloads (the Gradle example number is actually wrong, it should be 21.1.6352462, not 21.0.6352462, someone made an oops)

TacoTheDank commented 4 years ago

@PerfectSlayer Btw, is there any way for the transifex commits to be squashed when you're pulling them? I'd hate for someone to have to search through walls of this. It makes the commit history very messy tbh.

PerfectSlayer commented 4 years ago

h more experience lol. I have no idea what files are necessary or not, nor what changes might have to be made on the Java side.

There should not be needed to edit the Java part. For mongoose, that's only c and h file. Maybe have a look to the makefile. For libpcap and tcpdump, it might be trickier to make it work for Android. You need to give it a try to see what happens!

ight now is r21b https://developer.android.com/ndk/downloads (the Gradle example number is actually wrong, it

Oops, you're right. It seems I am not in the latest version!

@PerfectSlayer Btw, is there any way for the transifex commits to be squashed when you're pulling them? I'd hate for someone to have to search through walls of

Transifex bot makes a PR per translation resource. It's easier to identify when the build breaks (sometime due to some forbidden char sequences in locale files). It's easier for Vankog to fix it when need. And think about him, he has to merge it one by one! I get it its annoying but it should be temporary due to the new version. It should be quiet in the coming weeks ;)

Because it's not easier here.. There is branch everywhere! image

PerfectSlayer commented 4 years ago

I just update to latest NDK e3128a347e0700821074e5d615aa13066e122833

PerfectSlayer commented 4 years ago

I also update to the latest mongoose version 94e1388f