search

AdChain / AdChainRegistry

adChain registry smart contracts
Apache License 2.0
30 stars 10 forks source link

Naming convention in Listing Struct #15

Closed kangarang closed 6 years ago

kangarang commented 7 years ago

The currentDeposit member of the Listing struct in Registry.sol could be named differently to clarify it's purpose. During challenges, the currentDeposit is decreased by the challenger.

kangarang commented 7 years ago

Throwing some ideas out there:

  1. currentUnlockedDeposit
  2. currentStake
  3. currentUnlockedStake
kangarang commented 7 years ago
  1. unlockedDeposit
  2. unlockedStake
  3. unlockedTokens
  4. securityDeposit
  5. unlockedSecurityDeposit
skmgoldin commented 7 years ago

Lets call it unstakedDeposit. I will accept a PR to this effect.