search

AdChain / AdChainRegistry

adChain registry smart contracts
Apache License 2.0
30 stars 10 forks source link

Add natspec comments to Registry.sol #29

Closed kangarang closed 6 years ago

kangarang commented 6 years ago

Also made a minor semantic change: appExists is now appWasMade

skmgoldin commented 6 years ago

Natspec is only relevant to specifying function signatures, so lines like this: https://github.com/AdChain/AdChainRegistry/pull/29/files?diff=split#diff-b8a5e1960a14bc6ce88b5d1f3753a9a9R25

Where you're adding the third slash just to a regular comment, it's unnecessary. Otherwise looks good, remove those extra slashes and I'll merge this.

kangarang commented 6 years ago

Got it! Just fixed that. Thanks for the review @skmgoldin