search

AdChain / AdChainRegistry

adChain registry smart contracts
Apache License 2.0
30 stars 10 forks source link

Typo error #30

Closed eccheung4 closed 6 years ago

eccheung4 commented 6 years ago

https://github.com/AdChain/AdChainRegistry/blob/master/contracts/Registry.sol#L242 "==" instead of "="

skmgoldin commented 6 years ago

Damn, how did our tests not get this. Lets do a decomposition of that before fixing @kangarang. Thanks Ed.

skmgoldin commented 6 years ago

Good thing somebody is reading this code. 🙄

skmgoldin commented 6 years ago

I'm actually gonna do a hotfix right now Ed.

kangarang commented 6 years ago

Great catch @eccheung4 . @skmgoldin

We don't have any test coverage on claimReward and it's never invoked within Registry.sol, so at least we have that going for us.

skmgoldin commented 6 years ago

Hotfix committed, new contracts deployed to Rinkeby and pushed to S3.

We don't have any test coverage on claimReward

We gotta fill in those stubs.

eccheung4 commented 6 years ago

Same typo error

https://github.com/AdChain/AdChainRegistry/blob/master/contracts/Parameterizer.sol#L194

kangarang commented 6 years ago

Thanks @eccheung4 .

@skmgoldin is traveling at the moment and will redeploy the contracts probably in the next day or so.

eccheung4 commented 6 years ago

cool, no hurry to redeploy