search

AdRoll / goamz

Fork of the GOAMZ version developed within Canonical with additional functionality with DynamoDB
https://wiki.ubuntu.com/goamz
Other
401 stars 213 forks source link

parameter names should be sorted in v4signer #409

Closed nalin-humin closed 8 years ago

nalin-humin commented 9 years ago

http://docs.aws.amazon.com/general/latest/gr/sigv4-create-canonical-request.html 3.b Sort the encoded parameter names by character code (that is, in strict ASCII order).

currently, we seems to be sorting parameter name+value string.

alimoeeny commented 9 years ago

Please feel free to send a PR. Thanks. Also please include tests that test this specifically. Thanks again.

nalin-humin commented 9 years ago

i have fix ready, somehow, i am unable to run existing test itself. will check more

nalin-humin commented 8 years ago

please take a look at - https://github.com/AdRoll/goamz/pull/422 @alimoeeny