AdRoll / goamz

Fork of the GOAMZ version developed within Canonical with additional functionality with DynamoDB
https://wiki.ubuntu.com/goamz
Other
401 stars 213 forks source link

Adding S3 API methods GetACL + GetCannedPolicyByAcl for getting ACL from bucket and object #439

Closed bieli closed 7 years ago

bieli commented 7 years ago

In some cases in https://github.com/allegro/akubra supporting tool we need two methods:

It's important part to developing our next Open Source solution. This is my proposal of solution for below functionality and new features in S3 goamz package. Please comment and testing my code.

CLAassistant commented 7 years ago

CLA assistant check
All committers have signed the CLA.

alimoeeny commented 7 years ago

@bieli thanks. Looks like there is a formatting issue. Please fix it and try this to double check.

$ FIXIT=$(go fmt ./...); if [ -n "${FIXIT}" ]; then FIXED=$(echo $FIXIT | wc -l); echo "gofmt - ${FIXED} file(s) not formatted correctly, please run gofmt to fix them:\n ${FIXIT} " && exit 1; fi

alimoeeny commented 7 years ago

Hi @bieli thanks for the update can you please sign the CLA?

bieli commented 7 years ago

@alimoeeny I sign th CLA and I don't know what means one not accepted check licence/cla — Waiting for status to be reported ? It's required to verify on your side ?

alimoeeny commented 7 years ago

@bieli something is wrong. I am trying to contact the gods, who have admin access to this repo (I don't) and see if I can get them to fix it or give me access to fix it.

bieli commented 7 years ago

@alimoeeny Any news about licence/cla status ?

alimoeeny commented 7 years ago

@bieli there is a workaround for now, sorry for the delay. Merged.