AdRoll / goamz

Fork of the GOAMZ version developed within Canonical with additional functionality with DynamoDB
https://wiki.ubuntu.com/goamz
Other
401 stars 213 forks source link

Please add support for missing regions #443

Open liclac opened 5 years ago

liclac commented 5 years ago

According to this list: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/using-regions-availability-zones.html And this definition file: https://github.com/AdRoll/goamz/blob/master/aws/regions.go

This library's region support is somewhat spotty:

Discovered after I tried to use Docker Registry with a bucket in London ^^;;

I would add these myself, but I'm unsure of where to look up the required data. Will gladly help out if you can tell me though.

alimoeeny commented 5 years ago

Thanks @liclac please send a pr , most services use https://github.com/AdRoll/goamz/blob/master/aws/regions.go there are exceptions if I remember but let's not worry about them. I assume you know that this library is not meant to be used for new projects.