search

AdRoll / hologram

Easy, painless AWS credentials on developer laptops.
Apache License 2.0
803 stars 42 forks source link

Fix protobuf reference paths #28

Closed copumpkin closed 9 years ago

copumpkin commented 9 years ago

They were out of sync with the other ones. They're autogenerated files and I didn't bother regenerating them but this seems sufficient to get it compiling again.

copumpkin commented 9 years ago

I don't think the travis failure is related to this, but it's hard to be sure!

frangarciam commented 9 years ago

Thanks for the PR!

I think the tests are just github being flaky today, I'm having lots of issues downloading dependencies from here as well.

The good news is that your change is included in https://github.com/AdRoll/hologram/pull/27, which we're merging right now (in order for it to work we also need to modify the Godeps file so we can pull the right deps) so I'll close this one.

zylad commented 9 years ago

https://github.com/AdRoll/hologram/pull/27 has been merged, so this change is included there. Thanks for reporting, @copumpkin !

copumpkin commented 9 years ago

Great, thanks!