search

AdRoll / hologram

Easy, painless AWS credentials on developer laptops.
Apache License 2.0
803 stars 42 forks source link

Fix for terraform =>0.6.9 #71

Closed ikalinin closed 8 years ago

ikalinin commented 8 years ago

terraform has undergone some changes and it now checks if the metadata service responds before trying to get credentials from it, so we need to implement the /latest handler so it doesn't return a 404.

CLAassistant commented 8 years ago

CLA assistant check
All committers have accepted the CLA.

copumpkin commented 8 years ago

See also https://github.com/hashicorp/terraform/pull/5014

ikalinin commented 8 years ago

@copumpkin yeah, I saw that and decided we should fix this in hologram since it's probably going to be faster. I tested this yesterday and we also need to modify the response header, working on it right now.

radeksimko commented 8 years ago

Hi all, sorry for the troubles the recent changes in Terraform caused you.

I think I came up with a solution that may work better for both sides - Terraform & Hologram project:

By default Terraform will keep verifying "authenticity" of EC2 metadata endpoint, but will also allow the user to specify the endpoint URL via ENV variable AWS_METADATA_ENDPOINT. If user decides to do so Terraform won't perform any checks of that endpoint. The ENV variable can obviously be still the same as the default endpoint URL.

https://github.com/hashicorp/terraform/pull/5014#issuecomment-196004271

Does it sound like a plausible solution?

walterking commented 8 years ago

I think we'd rather just implement any missing bits you may rely on. One of the primary goals for this project was that it would just work without setting any variables locally, and adding a few mock responses will be easier than all of the support requests from it not working because they forgot to.

On Sunday, March 13, 2016, Radek Simko notifications@github.com wrote:

Hi all, sorry for the troubles the recent changes in Terraform caused you.

I think I came up with a solution that may work better for both sides - Terraform & Hologram project:

By default Terraform will keep verifying "authenticity" of EC2 metadata endpoint, but will also allow the user to specify the endpoint URL via ENV variable AWS_METADATA_ENDPOINT. If user decides to do so Terraform won't perform any checks of that endpoint. The ENV variable can obviously be still the same as the default endpoint URL.

hashicorp/terraform#5014 (comment) https://github.com/hashicorp/terraform/pull/5014#issuecomment-196004271

Does it sound like a plausible solution?

— Reply to this email directly or view it on GitHub https://github.com/AdRoll/hologram/pull/71#issuecomment-196004492.