AdRoll / hologram

Easy, painless AWS credentials on developer laptops.
Apache License 2.0
803 stars 42 forks source link

Replace gdp with Go 1.6+ built-in vendoring, update all deps to latest #82

Closed snwight closed 7 years ago

snwight commented 7 years ago

Replace gdp with Go 1.6+ built-in vendoring. Updated all deps to latest versions, vendored them all so we have a snapshot of today's state. I used govendor to init and sync, which is a sledgehammer approach and pulls in every last thing, which is what we probably want for this docker env. I made a single change to the source, in cmd/hologram-authorize/main.go to adapt for a recent change to gopass package. This builds and all tests - such as they are - pass under Go 1.7.1

CLAassistant commented 7 years ago

CLA assistant check
All committers have signed the CLA.

snwight commented 7 years ago

Low hanging fruit, part deux... cleaned up header comments for packages so the 'Overview' section isn't filled with license info, added godoc generation target to buildscripts (generate_docs.sh) which serves up HTML godocs to localhost:6060 as well as static type analysis of source (so the source refs have live ref links, useful for navigation in the absence of a Go-sensitive editor env)

snwight commented 7 years ago

thanks for the observation, @copumpkin - i'm a recent convert to jetbrains IDE (from emacs) ... adding .idea/ to .gitignore now