AdRoll / hologram

Easy, painless AWS credentials on developer laptops.
Apache License 2.0
803 stars 42 forks source link

Wrong path in the postinstall script. #85

Closed dialtone closed 7 years ago

walterking commented 7 years ago

what are you trying to do? im not sure if the current command /should/ exist, but running it as a launchdaemon wont work because hologram me needs to be an agent to know the logged in user to be able to read the correct ssh directory

dialtone commented 7 years ago

Well it can be whatever but the install scripts put it in the Daemon directory so if the right path is agents then we should install the plist there.

On Sun, Nov 20, 2016 at 19:42 Walter King notifications@github.com wrote:

what are you trying to do? im not sure if the current command /should/ exist, but running it as a launchdaemon wont work because hologram me needs to be an agent to know the logged in user to be able to read the correct ssh directory

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/AdRoll/hologram/pull/85#issuecomment-261823766, or mute the thread https://github.com/notifications/unsubscribe-auth/AABam7l2fjMdy7Lcg3Vtn4t76ZWtyXJ6ks5rAPcTgaJpZM4K3uKq .

walterking commented 7 years ago

oh, i get it. i dont see how it could work currently - i bet you all have an error from hologram-me.plist in your syslog every boot. the install script is probably the one that should be changed instead of postinstall for this to work as intended

dialtone commented 7 years ago

I think it currently works thanks to old copies of that file from older versions that still work as intended.

dialtone commented 7 years ago

alright, now switched to fix the installer

walterking commented 7 years ago

looks right to me 👍