Don't analyze files under `.erlang.mk`

AdRoll / rebar3_hank

The Erlang Dead Code Cleaner

MIT License

68 stars 9 forks source link

Don't analyze files under `.erlang.mk` #150

Closed elbrujohalcon closed 3 years ago

elbrujohalcon commented 3 years ago

erlang.mk generates a folder .erlang.mk and it includes tons of erl/hrl files that hank incorrectly includes in its analysis. We should ignore them.

_Originally posted by @elbrujohalcon in https://github.com/AdRoll/rebar3_hank/issues/149#issuecomment-883968488_

pbrudnick commented 3 years ago

Not sure about it, maybe is proper for the user to intentionally ignore folders (the README should help) like that and don't giving ignore support for specific tools.

elbrujohalcon commented 3 years ago

It's not a matter of ignoring it, @pbrudnick (i.e., the user can add it to the ignore list in rebar.config). It's a matter of not spending a lot of time analyzing it, when it's clearly not part of the user's project. Don't forget that, in Hank, ignore doesn't mean "don't analyze it", it means "don't show me the warnings" ;)

pbrudnick commented 3 years ago

Makes sense! 👍