search

AdRoll / rebar3_hank

The Erlang Dead Code Cleaner
MIT License
68 stars 9 forks source link

Change min otp version to 21 #74

Closed rjcoelho closed 3 years ago

rjcoelho commented 3 years ago

I'm using OTP 21 and don't intend to bump anytime soon and rebar3_format is in OTP21+

CLAassistant commented 3 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Rui Coelho seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

rjcoelho commented 3 years ago

Should I also update github workflow ? I'm on 21.3

elbrujohalcon commented 3 years ago

@rjcoelho Thanks for the pull request.

To be perfectly clear: We're fine with reducing minimum_otp_version to "21" if that works for you, but we won't provide active support for OTP21. We (NextRoll) moved all our infrastructure to OTP22 a while back and that means that we no longer test our systems in OTP21 or lower versions. This app was even created after that change and it was never tested (at least not internally) on OTP21.

That means that we won't update the github workflow as we won't commit ourselves to ensure OTP21 support.

rjcoelho commented 3 years ago

@elbrujohalcon it is fine by me. Thanks