search

AdWerx / charts

helm charts maintained by Adwerx Engineering
MIT License
25 stars 34 forks source link

[faktory] Add Kubernetes 1.16+ compatibility #10

Closed Envek closed 4 years ago

Envek commented 4 years ago

What this PR does / why we need it:

  1. Fix StatefulSet definition to be compatible with Kubernetes 1.16+

    StatefulSets were stabilized and thus removed from experimental apis in Kubernetes 1.16 (current version is 1.18).

    See https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/

    StatefulSet in the apps/v1beta1 and apps/v1beta2 API versions is no longer served

    Migrate to use the apps/v1 API version, available since v1.9. Existing persisted data can be retrieved/updated via the new version.

  2. Fix spacing issues that breaks manifest (apiVersion goes into preceding comment line)

Benefits

Compatibility with currently used stable k8s versions: 1.16+

Possible drawbacks

Broken compatibility with k8s before 1.9

Checklist

jbielick commented 4 years ago

LGTM. Thanks for the update and fix.

Envek commented 4 years ago

Thank you for rapid maintenance and chart publishing!